fix(cli): Re-add create validator

[itsdevbear]

Summary by CodeRabbit

• New Features

  • Introduced a command for creating validator deposits via the CLI, enhancing the deposit functionality.
  • Added flags for managing node and validator private key configurations, improving user control over deposit operations.

• Bug Fixes

  • Removed the outdated error declaration for deposit transaction failures, streamlining error handling.

• Documentation

  • Enhanced descriptions for new CLI flags to improve user guidance and experience.

• Chores

  • Updated dependency management to include cosmossdk.io/log as a direct dependency, optimizing logging capabilities.

[coderabbitai]

Walkthrough

The pull request introduces a new command for creating validator deposits in a CLI context, enhancing the functionality of the deposit package. It includes the implementation of a command to handle validator deposits, updates to error handling, and the addition of flag constants for managing node and validator private keys. Changes span multiple files, refining the overall command interface and improving error management.

Changes

Files	Change Summary
mod/cli/pkg/commands/deposit/create.go	Added a new CLI command for creating validator deposits, including functions for command construction, execution logic, and BLS signer retrieval.
mod/cli/pkg/commands/deposit/deposit.go	Enhanced the command registration process by including the new NewCreateValidator command to expand deposit operations.
mod/cli/pkg/commands/deposit/errors.go	Removed ErrDepositTransactionFailed error declaration, indicating a shift in error handling for deposit transactions while retaining ErrPrivateKeyRequired.
mod/cli/pkg/commands/deposit/flags.go	Introduced constants for command-line flags related to node and validator private keys, including default values and descriptive messages for user guidance.
mod/cli/go.mod	Added cosmossdk.io/log v1.4.1 as a direct dependency, reflecting a restructuring of the module's logging capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant DepositHandler
    participant BLSSigner
    participant Validator

    User->>CLI: Execute Create Validator Command
    CLI->>DepositHandler: Validate Arguments
    DepositHandler->>BLSSigner: Retrieve BLS Signer
    DepositHandler->>Validator: Create and Sign Deposit Message
    Validator-->>DepositHandler: Return Signed Message
    DepositHandler->>CLI: Log Deposit Message Details

Loading

🐇 "In the meadow, a change did bloom,
New commands to dispel the gloom.
With flags and keys, we hop along,
Creating deposits, where we belong.
A leap of joy, in code we trust,
For every validator, it's a must!"
🌼

Possibly related PRs

• Revert "test(proofs): consistency tests for working proof generation & verification" #2005: The changes in the main PR involve the addition of new CLI commands for creating validator deposits, which relates to the modifications in the beacond/cmd/defaults.go and beacond/cmd/main.go files that streamline type references and enhance command functionality.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 489bbd6 and 83595af.

Files selected for processing (1)

• mod/cli/go.mod (2 hunks)

Additional comments not posted (1)

mod/cli/go.mod (1)

25-25: Approved: Direct dependency on cosmossdk.io/log for enhanced logging control.

Adding cosmossdk.io/log as a direct dependency in the require section and removing it from the indirect dependencies indicates that the module now directly leverages this logging package. This change can provide more fine-grained control over logging functionality and can help in optimizing the logging setup according to the module's specific needs.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes missing coverage. Please review.

Project coverage is 21.56%. Comparing base (76943ea) to head (83595af).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
mod/cli/pkg/commands/deposit/create.go	0.00%	96 Missing ⚠️
mod/cli/pkg/commands/deposit/deposit.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
- Coverage   21.70%   21.56%   -0.14%     
==========================================
  Files         356      357       +1     
  Lines       15917    16014      +97     
  Branches       13       13              
==========================================
  Hits         3454     3454              
- Misses      12343    12440      +97     
  Partials      120      120              

Files with missing lines	Coverage Δ
mod/cli/pkg/commands/deposit/deposit.go	0.00% <0.00%> (ø)
mod/cli/pkg/commands/deposit/create.go	0.00% <0.00%> (ø)