Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line break to uploaded message #47

Closed
wants to merge 1 commit into from

Conversation

satotake
Copy link
Contributor

@satotake satotake commented Mar 30, 2019

s3deploy has 3 types of output about file handling.

  1. upload
  2. delete (verbose only)
  3. skip (verbose only)

delete and skip messages has a line break at the end of string.
On the other hand upload has whitespace instead of \n

I would like to add line breaks upload messages.

@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #47 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   67.12%   67.29%   +0.17%     
==========================================
  Files           8        8              
  Lines         581      581              
==========================================
+ Hits          390      391       +1     
+ Misses        161      160       -1     
  Partials       30       30
Impacted Files Coverage Δ
lib/deployer.go 81.32% <100%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de166f3...9ee71f7. Read the comment docs.

@bep
Copy link
Owner

bep commented Mar 30, 2019

I implemented it like this for a good reason. Changing it would require an even better reason, which would need more language than "I would like".

@satotake
Copy link
Contributor Author

satotake commented Mar 30, 2019

Thank you for your response.

The reason is consistency about output formatting and readability.

For example, I wrote a script, which reads s3deploy's output to monitor which files are mutated in remote.
Therefore, if it shows one message per single line, parsing would be easier.

@satotake
Copy link
Contributor Author

satotake commented Mar 30, 2019

Current implementation of this PR changes all upload messages.

If you mind it, how do you think about inserting line breaks into upload message only if verbose mode?

@satotake
Copy link
Contributor Author

I missed #45 , sorry but it is related to this PR

@satotake satotake closed this Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants