forked from gohugoio/hugo
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tpl/tplimpl: Fix template truth logic
Fixes gohugoio#5738
- Loading branch information
Showing
16 changed files
with
435 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Copyright 2019 The Hugo Authors. All rights reserved. | ||
| // Some functions in this file (see comments) is based on the Go source code, | ||
| // copyright The Go Authors and governed by a BSD-style license. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package hreflect contains reflect helpers. | ||
| package hreflect | ||
|
|
||
| import "reflect" | ||
|
|
||
| // Indirect returns the item at the end of indirection, and a bool to indicate | ||
| // if it's nil. If the returned bool is true, the returned value's kind will be | ||
| // either a pointer or interface. | ||
| // Based on: https://github.com/golang/go/blob/178a2c42254166cffed1b25fb1d3c7a5727cada6/src/text/template/exec.go#L918 | ||
| func Indirect(v reflect.Value) (rv reflect.Value, isNil bool) { | ||
| for ; v.Kind() == reflect.Ptr || v.Kind() == reflect.Interface; v = v.Elem() { | ||
| if v.IsNil() { | ||
| return v, true | ||
| } | ||
| if v.Kind() == reflect.Interface && v.NumMethod() > 0 { | ||
| break | ||
| } | ||
| } | ||
| return v, false | ||
| } | ||
|
|
||
| // indirectInterface returns the concrete value in an interface value, | ||
| // or else the zero reflect.Value, and a boolean indicating if it is nil. | ||
| // That is, if v represents the interface value x, the result is the same as reflect.ValueOf(x): | ||
| // the fact that x was an interface value is forgotten. | ||
| // Based on: https://github.com/golang/go/blob/178a2c42254166cffed1b25fb1d3c7a5727cada6/src/text/template/exec.go#L931 | ||
| func IndirectInterface(v reflect.Value) (rv reflect.Value, isNil bool) { | ||
| for ; v.Kind() == reflect.Interface; v = v.Elem() { | ||
| if v.IsNil() { | ||
| return v, true | ||
| } | ||
| if v.Kind() == reflect.Interface && v.NumMethod() > 0 { | ||
| break | ||
| } | ||
| } | ||
| return v, false | ||
| } | ||
|
|
||
| func IsTruthful(in interface{}) bool { | ||
| switch v := in.(type) { | ||
| case reflect.Value: | ||
| return IsTruthfulValue(v) | ||
| default: | ||
| return IsTruthfulValue(reflect.ValueOf(in)) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| type zeroer interface { | ||
| IsZero() bool | ||
| } | ||
|
|
||
| var zeroType = reflect.TypeOf((*zeroer)(nil)).Elem() | ||
|
|
||
| // IsTruthful returns whether the given value has a meaningful truth value. | ||
| // This is based on template.IsTrue in Go's stdlib, but also considers | ||
| // IsZero and any interface value will be unwrapped before it's considered | ||
| // for truthfulness. | ||
| // | ||
| // Based on: | ||
| // https://github.com/golang/go/blob/178a2c42254166cffed1b25fb1d3c7a5727cada6/src/text/template/exec.go#L306 | ||
| func IsTruthfulValue(val reflect.Value) (truth bool) { | ||
| if !val.IsValid() { | ||
| // Something like var x interface{}, never set. It's a form of nil. | ||
| return false | ||
| } | ||
|
|
||
| val, _ = IndirectInterface(val) | ||
|
|
||
| if val.Type().Implements(zeroType) { | ||
| return !val.Interface().(zeroer).IsZero() | ||
| } | ||
|
|
||
| switch val.Kind() { | ||
| case reflect.Array, reflect.Map, reflect.Slice, reflect.String: | ||
| truth = val.Len() > 0 | ||
| case reflect.Bool: | ||
| truth = val.Bool() | ||
| case reflect.Complex64, reflect.Complex128: | ||
| truth = val.Complex() != 0 | ||
| case reflect.Chan, reflect.Func, reflect.Ptr, reflect.Interface: | ||
| truth = !val.IsNil() | ||
| case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: | ||
| truth = val.Int() != 0 | ||
| case reflect.Float32, reflect.Float64: | ||
| truth = val.Float() != 0 | ||
| case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr: | ||
| truth = val.Uint() != 0 | ||
| case reflect.Struct: | ||
| truth = true // Struct values are always true. | ||
| default: | ||
| return | ||
| } | ||
| return truth | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright 2019 The Hugo Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package hreflect | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestIsTruthFul(t *testing.T) { | ||
| assert := require.New(t) | ||
|
|
||
| assert.True(IsTruthful(true)) | ||
| assert.False(IsTruthful(false)) | ||
| assert.True(IsTruthful(time.Now())) | ||
| assert.False(IsTruthful(time.Time{})) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.