Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): use annotated type from typing_compat #943

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

rudeigerc
Copy link
Contributor

Use annotated type from typing_compat instead for compatibility with Python 3.8.

@rudeigerc rudeigerc requested a review from aarnphm as a code owner March 30, 2024 05:53
@aarnphm aarnphm changed the title fix: use annotated type from typing_compat instead for compatibility fix(compat): use annotated type from typing_compat Apr 2, 2024
@aarnphm aarnphm merged commit 7c9fd85 into bentoml:main Apr 2, 2024
1 check passed
@aarnphm
Copy link
Collaborator

aarnphm commented Apr 2, 2024

Oh I forgot to mention, I will drop 3.8 support for 0.5 :)

@rudeigerc rudeigerc deleted the fix/annotated branch April 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants