-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Simplify packaging docs #5116
docs: Simplify packaging docs #5116
Conversation
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
For more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 5 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- base_image
- amazonlinux
- distro
- debian
- pathspecs
- setup_script
- python_version
- requirements_txt
- trusted_host
- Conda
- cuda_version
- prepended
- Dockerfile
- Bentos
- distros
- system_packages
- no_index
- lock_packages
- index_url
- dockerfile_template
- bento
- find_links
- Distro
- conda
- extra_index_url
- pip_args
- Bento
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 4 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- [Pp]athspecs
- BentoCloud
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 3 total issue(s) found.
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 3 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- [Dd]istro
- build_ctx
What does this PR address?
This pr simplifies the existing Bento packaging doc.
Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.