Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(1.4): Make the cloud client APIs more structured and aligned #4972

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Sep 12, 2024

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Make the cloud client APIs more structured and aligned

import bentoml
import os

# Use default client
deployment = bentoml.deployment.get('mydeployment')
# Use from cloud client
client = bentoml.BentoCloudClient("token")
deployment = client.deployment.get("mydeployment")
# Env vars are supported
os.environ['BENTO_CLOUD_API_KEY'] = 'mytoken'
os.environ['BENTO_CLOUD_API_ENDPOINT'] = 'https://my.cloud.bentoml.org'
client = bentoml.BentoCloudClient()
deployment = client.deployment.get("mydeployment")

@frostming frostming requested a review from a team as a code owner September 12, 2024 09:00
@frostming frostming requested review from xianml and removed request for a team September 12, 2024 09:00
@frostming frostming changed the title refactor: restructure the code of bentocloud client refactor: Make the cloud client APIs more structured and aligned Sep 12, 2024
@frostming frostming changed the title refactor: Make the cloud client APIs more structured and aligned refactor(1.4): Make the cloud client APIs more structured and aligned Sep 12, 2024
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit ff88cc6 into bentoml:dev/1.4 Sep 13, 2024
48 of 49 checks passed
@frostming frostming deleted the refactor/cloud-client branch September 13, 2024 02:37
frostming added a commit that referenced this pull request Sep 13, 2024
…#4972)

* refactor: restructure the code of bentocloud client

Signed-off-by: Frost Ming <me@frostming.com>

* fix bentoml version in developing

Signed-off-by: Frost Ming <me@frostming.com>

* fix: include hidden files for upload

Signed-off-by: Frost Ming <me@frostming.com>

* fix: upload to individual artifacts

Signed-off-by: Frost Ming <me@frostming.com>

---------

Signed-off-by: Frost Ming <me@frostming.com>
frostming added a commit that referenced this pull request Sep 20, 2024
…#4972)

* refactor: restructure the code of bentocloud client

Signed-off-by: Frost Ming <me@frostming.com>

* fix bentoml version in developing

Signed-off-by: Frost Ming <me@frostming.com>

* fix: include hidden files for upload

Signed-off-by: Frost Ming <me@frostming.com>

* fix: upload to individual artifacts

Signed-off-by: Frost Ming <me@frostming.com>

---------

Signed-off-by: Frost Ming <me@frostming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants