Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): make sure to install .tar.gz wheels #4755

Closed
wants to merge 1 commit into from

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented May 26, 2024

this will fix installing bentoml dev wheels.

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner May 26, 2024 07:35
@aarnphm aarnphm requested review from frostming and removed request for a team May 26, 2024 07:35
@frostming
Copy link
Contributor

Why do we need to install tar.gz separately? the dev sdist will be added to the requirements.txt:

elif sdist_name:
f.write(f"./wheels/{sdist_name}\n")

@aarnphm
Copy link
Contributor Author

aarnphm commented May 27, 2024

Why do we need to install tar.gz separately? the dev sdist will be added to the requirements.txt:

elif sdist_name:
f.write(f"./wheels/{sdist_name}\n")

currently we only check for ending with *.whl. this means .tar.gz won't be installed.

@frostming
Copy link
Contributor

frostming commented May 28, 2024

currently we only check for ending with *.whl. this means .tar.gz won't be installed.

I mean we add them into the requirements.txt and it will be picked up by pip install -r requirements.txt, and it will perform a resolution step so it is preferred over directly installing from the file only

@aarnphm
Copy link
Contributor Author

aarnphm commented May 28, 2024

oh what happened to custom .tar.gz that can be installed with pip?

I guess I run into this issue with openllm, but then wrote a dockerfile template to install the custom .tar.gz separately.

edit: I think for this case users should write custom dockerfile template then, since installing arbitrary tar seems like a bad idea regardless.

@frostming
Copy link
Contributor

oh what happened to custom .tar.gz that can be installed with pip?

How to add these tarballs? we only support python.wheels in build config

@aarnphm
Copy link
Contributor Author

aarnphm commented May 29, 2024

hmm I guess wheels=[wheel_fs.getsyspath(f"/{i.split('/')[-1]}") for i in built_wheels].

but probably out of scope. I don't think this is needed.

@aarnphm aarnphm closed this May 29, 2024
@aarnphm aarnphm deleted the fix/install-tar-wheels branch June 6, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants