Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: asign runner name #2139

Merged
merged 3 commits into from
Dec 24, 2021
Merged

refactor: asign runner name #2139

merged 3 commits into from
Dec 24, 2021

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Dec 23, 2021

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #2139 (74794c0) into main (30edb7b) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

❗ Current head 74794c0 differs from pull request most recent head c68595a. Consider uploading reports for the commit c68595a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
- Coverage   45.85%   45.81%   -0.04%     
==========================================
  Files          93       93              
  Lines        7799     7893      +94     
==========================================
+ Hits         3576     3616      +40     
- Misses       4223     4277      +54     
Impacted Files Coverage Δ
bentoml/_internal/frameworks/easyocr.py 72.22% <0.00%> (-3.15%) ⬇️
bentoml/_internal/frameworks/gluon.py 62.33% <0.00%> (-2.53%) ⬇️
bentoml/_internal/frameworks/h2o.py 65.75% <0.00%> (-2.82%) ⬇️
bentoml/_internal/frameworks/paddle.py 77.95% <25.00%> (-12.67%) ⬇️
bentoml/_internal/frameworks/pytorch_lightning.py 64.40% <25.00%> (-33.03%) ⬇️
bentoml/_internal/runner/runner.py 71.42% <47.36%> (-0.11%) ⬇️
bentoml/_internal/service/service.py 74.11% <80.00%> (-0.89%) ⬇️
bentoml/_internal/frameworks/catboost.py 98.83% <100.00%> (+0.04%) ⬆️
bentoml/_internal/frameworks/detectron.py 95.91% <100.00%> (+0.12%) ⬆️
bentoml/_internal/frameworks/keras.py 98.00% <100.00%> (+0.06%) ⬆️
... and 14 more

@bojiang bojiang changed the title refactor: asgin runner name refactor: asign runner name Dec 23, 2021
import pandas as pd
import psutil
import pytest
import torch.nn as nn
import pytorch_lightning as pl
import setuptools # type: ignore[reportUnusedImport] noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import setuptools # type: ignore[reportUnusedImport] noqa: F401
import setuptools # type: ignore[reportUnusedImport] # noqa: F401


import bentoml
from tests.utils.helpers import assert_have_file_extension

import torch # isort:skip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to fix this pypa/setuptools#2230 but not work. will ignore it

@bojiang bojiang enabled auto-merge (squash) December 23, 2021 18:34
@bojiang bojiang merged commit 5ab95a6 into bentoml:main Dec 24, 2021
@bojiang bojiang deleted the fix branch December 24, 2021 02:27
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* refactor: runner name

* fix

* fix for transformers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants