-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration option to disable logs in production #1009
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
cc @bojiang as discussed - add the following CLI arg to bentoml API server: |
I'm going take a stab at this problem next. Discussed offline with @yubozhao, we think the best option might to be generically expose the full logging configuration rather than just the log-to-file option, so we can hopefully solve all logging customization needs. My plan is to expose the logging configuration through CLI param and environment variable in that priority order while maintaining a reasonable default like the one in log.py. Docker and K8s can hopefully leverage it without much change. Please let me know your thoughts. |
#1365) * [Enhancement] Allow full logging customization through YAML configuration (#1009) * Add yaml to install_requires in setup.py * Use ruamel.yaml instead of yaml for parsing logging configuration and remove local file handlers for prediction and feedback loggers * Address linter errors and update documentation. * Addressed pull request comments. - Added configuration for disabling console and file logging - Added unit test for log.py - Added documentation for configuration in general - Updated documentation for logging * Added debug logging to specify where logging configuration was loaded from. * Fix unit test file permission issue on Windows. * Update documentation log file examples.
Thank you @ssheng for working on this issue. I think this is a great addition to the community. @shihgianlee This feature will be part of the next release. Feel free to reopen this issue, if you have additional questions. |
bentoml#1365) * [Enhancement] Allow full logging customization through YAML configuration (bentoml#1009) * Add yaml to install_requires in setup.py * Use ruamel.yaml instead of yaml for parsing logging configuration and remove local file handlers for prediction and feedback loggers * Address linter errors and update documentation. * Addressed pull request comments. - Added configuration for disabling console and file logging - Added unit test for log.py - Added documentation for configuration in general - Updated documentation for logging * Added debug logging to specify where logging configuration was loaded from. * Fix unit test file permission issue on Windows. * Update documentation log file examples.
bentoml#1365) * [Enhancement] Allow full logging customization through YAML configuration (bentoml#1009) * Add yaml to install_requires in setup.py * Use ruamel.yaml instead of yaml for parsing logging configuration and remove local file handlers for prediction and feedback loggers * Address linter errors and update documentation. * Addressed pull request comments. - Added configuration for disabling console and file logging - Added unit test for log.py - Added documentation for configuration in general - Updated documentation for logging * Added debug logging to specify where logging configuration was loaded from. * Fix unit test file permission issue on Windows. * Update documentation log file examples.
Is your feature request related to a problem? Please describe.
We have a mechanism to capture logs in production that doesn't require log files collection. However, there is no option to disable local log files generation.
Describe the solution you'd like
A configuration option for user to disable logging to files.
Describe alternatives you've considered
Accept the default behavior since log rotation is in place. There is no concerns that the log files will grow large and eat up disk space on the server.
The text was updated successfully, but these errors were encountered: