fix: stop live refresh before showing final status

Signed-off-by: Frost Ming <me@frostming.com>
bentoml · Jun 18, 2024 · cdc238b · cdc238b
1 parent ba22c4a
commit cdc238b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/bentoml/_internal/cloud/base.py b/src/bentoml/_internal/cloud/base.py
@@ -136,11 +136,11 @@ def start(self) -> None:
 
     def stop(self) -> None:
         """Stop live updating."""
-        self._live.stop()
         if self._spinner_task_id is not None:
             self._spinner_progress.stop_task(self._spinner_task_id)
             self._spinner_progress.update(self._spinner_task_id, visible=False)
             self._spinner_task_id = None
+        self._live.stop()
 
     def log(self, message: str) -> None:
         """Add a log message line."""

diff --git a/src/bentoml/_internal/cloud/deployment.py b/src/bentoml/_internal/cloud/deployment.py
@@ -580,10 +580,11 @@ def stop_tail_thread():
                             )
                             tail_thread.start()
 
-                    if (
-                        status.status == DeploymentStatus.Running.value
-                        or status.status == DeploymentStatus.ScaledToZero.value
+                    if status.status in (
+                        DeploymentStatus.Running.value,
+                        DeploymentStatus.ScaledToZero.value,
                     ):
+                        spinner.stop()
                         spinner.console.print(
                             f'✅ [bold green] Deployment "{self.name}" is ready:[/] {self.admin_console}'
                         )
@@ -595,13 +596,15 @@ def stop_tail_thread():
                         DeploymentStatus.Terminating.value,
                         DeploymentStatus.Unhealthy.value,
                     ]:
+                        spinner.stop()
                         spinner.console.print(
                             f'🚨 [bold red]Deployment "{self.name}" is not ready. Current status: "{status.status}"[/]'
                         )
                         return
 
                     time.sleep(check_interval)
 
+                spinner.stop()
                 spinner.console.print(
                     f'🚨 [bold red]Time out waiting for Deployment "{self.name}" ready[/]'
                 )