Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional details to Concurrency Control explanation #695

Merged
merged 3 commits into from
Aug 14, 2022
Merged

Add additional details to Concurrency Control explanation #695

merged 3 commits into from
Aug 14, 2022

Conversation

bensheldon
Copy link
Owner

Connects to #694

@bensheldon bensheldon temporarily deployed to goodjob-concurrency-doc-hm8raw August 10, 2022 15:18 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-concurrency-doc-d2nowk August 10, 2022 16:12 Inactive
shouichi
shouichi reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@shouichi shouichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand it correctly, we should emphasize that the primary mechanism of concurrency control is the number of threads/processes. Then explain that using good_job_control_concurrency_with as an additional barrier is a good idea. Make sense?

@bensheldon bensheldon temporarily deployed to goodjob-concurrency-doc-vquz70 August 14, 2022 00:19 Inactive
@bensheldon
Copy link
Owner Author

@shouichi Hmmm. It really depends on your concurrency needs. Someone may just want to prevent two jobs with the same arguments from being performed at the same time.

@bensheldon bensheldon temporarily deployed to goodjob-concurrency-doc-vquz70 August 14, 2022 14:22 Inactive
@bensheldon bensheldon merged commit a0811a4 into main Aug 14, 2022
@bensheldon bensheldon deleted the concurrency-docs branch August 14, 2022 19:33
@bensheldon bensheldon added the documentation Improvements or additions to documentation label Aug 14, 2022
@shouichi shouichi mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shouichi shouichi shouichi left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensheldon @shouichi