Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron_enabled attribute to good_job and pass it to process current state #675

Merged

Conversation

saksham-jain
Copy link
Contributor

  • Add cron_enabled attribute to good_job.
  • Set this attribute on initialization using enable_cron key in configuration.
  • Add new key cron_enabled to process current_state and use GoodJob.cron_enabled to set this key.

lib/good_job.rb Outdated Show resolved Hide resolved
@saksham-jain saksham-jain force-pushed the add-cron-enabled-key-to-process-state branch from 6952bb7 to ee77c9f Compare July 29, 2022 14:24
@bensheldon
Copy link
Owner

@saksham-jain could you please fix up the lint warning? This looks good 👍🏻

Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 thank you!

@bensheldon bensheldon merged commit 36f8ca6 into bensheldon:main Aug 5, 2022
@bensheldon
Copy link
Owner

@saksham-jain Thank you for the PR. I really appreciate this! Are you interested in further issues?

Just having worked through with this, I see a few jumping off points for improvement:

  • Rename that configuration option to be Configuration#cron_enabled? so it's consistent and the less awkward construction.
  • Could you go through Configuration and propose other configuration options you think would be meaningful to expose on the process state for debugging in the dashboard?

@saksham-jain
Copy link
Contributor Author

Thanks, @bensheldon. I will check these points.

@bensheldon bensheldon added the enhancement New feature or request label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants