Dashboard UI updates: sticky navbar, statuses as tabs

[bkeepers]

I spent a few hours today playing around with a couple things that I would love to see improved with the dashboard.

1. Make navbar sticky instead of footer (which doesn't really contain actionable information)
2. Elevate the status filter to tabs. That is what I personally filter by most often.
3. Move all filters above the chart since they affect the chart data.

[bensheldon]

@bkeepers I think this looks fantastic. I think changing the States to Tabs is a big improvement. I like that the States are all immediately visible/discoverable rather than obscured within a dropdown.

I'm more than happy to merge this as is (not let perfect be the enemy of better). I'll share some other thoughts in the discussion you opened.

[bkeepers]

@bensheldon sounds good. This should be ready whenever you are.

[bensheldon]

👍 Thank you!

Lemme know if I can help get the tests passing. I'm eager to get this merged.

[bkeepers]

Tests should all be passing now.

[bensheldon]

@bkeepers btw, while it's fresh in your mind, I'd love if you have any feedback/suggestions for improving the Readme's contributor section for getting started.

[bkeepers]

@bkeepers btw, while it's fresh in your mind, I'd love if you have any feedback/suggestions for improving the Readme's contributor section for getting started.

At first I didn't realize there was a test rails app that generates jobs, so that would have saved me some time getting another app set up and in a state where I could see jobs in various states. Just documenting bin/test_app server would be great.

[multiplegeorges]

@bkeepers Just updated the gem and saw that the filter dropdowns I added were gone, but the tabs are way better! Looks great, much more discoverable and surfacing the number in each is great for scanning.

👍

[bensheldon]

@multiplegeorges yay! Glad you like it too! 🎉

@bkeepers I was staring at the tab counts working on #578 and realized that I think the tab counts are incorrect: the numbers should be within the context of the filter, not absolute. If I made that change to have counts relative to the filter, I think the other filter options (Job Class, Queues, Search) should go above the tabs. Functionally I don't think anything would change though 🤔

These counts should be based off of filtered_query not base_query:

good_job/engine/app/filters/good_job/jobs_filter.rb

Lines 4 to 13 in c548fb7

	def states
	{
	'scheduled' => base_query.scheduled.count,
	'retried' => base_query.retried.count,
	'queued' => base_query.queued.count,
	'running' => base_query.running.count,
	'finished' => base_query.finished.count,
	'discarded' => base_query.discarded.count,
	}
	end

[bkeepers]

@bkeepers I was staring at the tab counts working on #578 and realized that I think the tab counts are incorrect…

@bensheldon ah, good catch. I can get a PR for that soon unless someone beats me to it.

If I made that change to have counts relative to the filter, I think the other filter options (Job Class, Queues, Search) should go above the tabs.

I was actually thinking about moving the filters inline with the tabs, hidden behind a filter icon with a dropdown menu. Not sure if that makes sense, but I'll get a PR open for it soon so we can discuss.