Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Limiting concurrency - fetch symbol instead of string #510

Conversation

BenSto
Copy link
Contributor

@BenSto BenSto commented Feb 2, 2022

Hi,

first of all thanks for the great work, indeed a good job!

I found a minor mistake in the README regarding the concurrency limitation when using a keyword argument. Currently it says to use [] with a string, but the key in the arguments hash is a symbol, so the expression always turns into nil .
Like proposed in this PR it should be a symbol instead of a string and I think it is also better to use .fetch instead of [], so it raises immediately a KeyError instead of turning silently into nil, if the key does not exist.

Feel free to just adapt the README and close this PR.

@bensheldon
Copy link
Owner

@BenSto thanks for flagging this! I just made a few tweaks and will merge. Thank you! 🎉

@bensheldon bensheldon added the documentation Improvements or additions to documentation label Feb 2, 2022
@BenSto
Copy link
Contributor Author

BenSto commented Feb 2, 2022

Thank you!

@bensheldon I have to say thank you, first for the fast response and second for the great work.

@bensheldon bensheldon merged commit 5b51dba into bensheldon:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants