README: Limiting concurrency - fetch symbol instead of string #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all thanks for the great work, indeed a good job!
I found a minor mistake in the README regarding the concurrency limitation when using a keyword argument. Currently it says to use
[]
with a string, but the key in the arguments hash is a symbol, so the expression always turns intonil
.Like proposed in this PR it should be a symbol instead of a string and I think it is also better to use
.fetch
instead of[]
, so it raises immediately aKeyError
instead of turning silently intonil
, if the key does not exist.Feel free to just adapt the README and close this PR.