Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development Ruby to 2.6.6 and gems #29

Merged
merged 1 commit into from
Jul 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ jobs:
# /Dependencies

- name: Set up test database
run: |
cd spec/dummy
bin/rails db:test:prepare
run: bin/rails db:test:prepare
working-directory: spec/dummy
- name: Run tests
run: bundle exec appraisal bin/rspec
22 changes: 4 additions & 18 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
inherit_from: .rubocop_todo.yml

require:
- rubocop-rspec

Expand All @@ -16,6 +18,7 @@ AllCops:
- pkg/**/*
- spec/dummy/**/*
- vendor/**/*
NewCops: enable

Layout/EmptyLineAfterMagicComment:
Enabled: false
Expand All @@ -32,24 +35,7 @@ Layout/ParameterAlignment:
Lint/AmbiguousBlockAssociation:
Enabled: false

Metrics/AbcSize:
Enabled: false

Metrics/BlockLength:
Enabled: false

Metrics/CyclomaticComplexity:
Enabled: false

Metrics/ClassLength:
CountComments: false # count full line comments?
Max: 500

Metrics/MethodLength:
CountComments: false # count full line comments?
Max: 100

Metrics/PerceivedComplexity:
Metrics:
Enabled: false

Naming/MemoizedInstanceVariableName:
Expand Down
29 changes: 29 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2020-07-13 18:57:43 UTC using RuboCop version 0.88.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AllowAliasSyntax, AllowedMethods.
# AllowedMethods: alias_method, public, protected, private
Layout/EmptyLinesAroundAttributeAccessor:
Exclude:
- 'lib/good_job/lockable.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
Exclude:
- 'bin/lint'

# Offense count: 2
# Cop supports --auto-correct.
Style/RedundantRegexpEscape:
Exclude:
- 'spec/support/sql_helper.rb'
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.6.5
2.6.6
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,5 @@ gemspec
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.

gem "appraisal", github: 'thoughtbot/appraisal' # https://github.com/thoughtbot/appraisal/pull/165

# To use a debugger
# gem 'byebug', group: [:development, :test]
Loading