Implement enqueue_after_transaction_commit?

[luizkowalski]

Closes #1310

It defines whether the job should be enqueued implicitly after committing an ActiveRecord transaction. More details here

[luizkowalski]

I'm just not sure how to test it here since this is just an option passed to AJ, and it is being tested there already. Do you have any idea?

[bensheldon]

Let's set the default to false because we do have the option of transactional integrity. Otherwise this looks good 👍

[bensheldon]

And don't worry about tests. We'll trust Active Job.

[luizkowalski]

it is worth mentioning that I tested locally with my app, and it worked

[luizkowalski]

I am scratching my head trying to fix the failure: using instance_double to double ActiveJob::QueueAdapters::InlineAdapter doesn't work on Rails edge but works for GA versions. Adding :enqueue_after_transaction_commit? false then works on edge but fails on GA since the commit was not backported (nor do I think it will?). I could change to double instead. It's not ideal, but it gives us the flexibility to handle different versions of InlineAdapter.

Have you seen such a problem? what's your take on this one? There's only one other place where double is used in tests, so I know it is not the preferred way to go

[bensheldon]

hmm. It's not pretty but what about something like this?

optional_adapter_kwargs = ActiveJob::QueueAdapters::InlineAdapter.method_defined?(:enqueue_after_transaction_commit?) ? { enqueue_after_transaction_commit?: false } : {}
adapter = instance_double(ActiveJob::QueueAdapters::InlineAdapter, enqueue: nil, enqueue_at: nil, **optional_adapter_kwargs)

[luizkowalski]

that should do it

[bensheldon]

Thanks for all the help on this! I decided to lift it up to a global configuration because the reason why someone would use this---they're using a separate database for jobs---would be a global decision rather than per-Adapter. I'll get this merged and cut a release and unblock you 🚀

[luizkowalski]

that’s actually a great idea! thanks for the quick follow up, ben! ❤️

[bensheldon]

Released! https://github.com/bensheldon/good_job/releases/tag/v3.27.4