Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: 4023228 ("let's exception not bubble") #3275

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Aug 14, 2024

  1. Revert "let's exception not bubble"

    This reverts commit 4023228.
    
    We use sys.exit. On purpose.
    We should therefore not be catching SystemExit.
    pajod committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1fcadcb View commit details
    Browse the repository at this point in the history
  2. workaround: reintroduce gevent.Timeout handling

    This is probably wrong. But less wrong than handling *all*
    BaseException. Reports of this happening may be the result of
     some *other* async Timeout in the wsgi app bubbling through to us.
    
    Gevent docs promise:
    "[..] if *exception* is the literal ``False``, the timeout is still raised,
       but the context manager suppresses it, so
       the code outside the with-block won't see it."
    pajod committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8617c39 View commit details
    Browse the repository at this point in the history
  3. style: line break

    pajod committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ef94875 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Partially revert "unconditionally log request error"

    There is not need to excessively produce high-severity logs, while
    there are ways to reach that point from entirely benign network errors.
    
    This partially reverts commit 0b10cba.
    pajod committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    27be287 View commit details
    Browse the repository at this point in the history