Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse requests with invalid and dangerous CR/LF/NUL in header field value, as demanded by rfc9110 section 5.5 #3253

Merged
merged 3 commits into from
Aug 6, 2024

Commits on Jul 30, 2024

  1. update docs

    pajod committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e3fa50d View commit details
    Browse the repository at this point in the history
  2. forbid lone CR/LF and NUL in headers

    New parser rule: refuse HTTP requests where a header field value
    contains characters that
    a) should never appear there in the first place,
    b) might have lead to incorrect treatment in a proxy in front, and
    c) might lead to unintended behaviour in applications.
    
    From RFC 9110 section 5.5:
    "Field values containing CR, LF, or NUL characters are invalid and
    dangerous, due to the varying ways that implementations might parse
    and interpret those characters; a recipient of CR, LF, or NUL within
    a field value MUST either reject the message or replace each of those
    characters with SP before further processing or forwarding of that
    message."
    pajod committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    eda9d45 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    70a1e43 View commit details
    Browse the repository at this point in the history