Use plain socket objects instead of wrapper classes #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilgovi
force-pushed
the
unwrapped-sockets
branch
from
e4a2331
to
bb6c318
Compare
Refactor socket creation to remove the socket wrapper classes so that these objects have less surprising behavior when used in worker hooks, worker classes, and custom applications. Close #3013.
tilgovi
force-pushed
the
unwrapped-sockets
branch
from
bb6c318
to
a24ff07
Compare
|
is there anything else missing for this? |
|
@benoitc polite bump, if you have the time |
benoitc
reviewed
Mar 6, 2024
| if i < 5: | ||
| msg = "connection to {addr} failed: {error}" | ||
| log.debug(msg.format(addr=str(addr), error=str(e))) | ||
| log.error("Retrying in 1 second.") |
|
@tilgovi is this ready for review or do yui think to any other addition/changes already? |
|
@tilgovi What is the status of your PR? |
benoitc
reviewed
Apr 17, 2024
gunicorn/sock.py
Outdated
| # first initialization of gunicorn | ||
| old_umask = os.umask(conf.umask) | ||
| try: | ||
| for addr in [bind for bind in conf.address if not isinstance(bind, int)]: |
There was a problem hiding this comment.
can you make this part more readable. I would create the bind list in a separate line there.
Implementing suggestion by reviewer #3127 (comment) to make code more readable.
|
Should the monkey patching in I was able to run my WIP request after reloading test against your PR after fixing just the following variable access: - sockets.append(socket.socket(s.FAMILY, socket.SOCK_STREAM,
- fileno=s.sock.fileno()))
+ sockets.append(socket.socket(s.family, socket.SOCK_STREAM,
+ fileno=s.fileno()))EDIT: rebased a24ff07 - including the above fix here: |
6 tasks
Update sock.py by making bind list creation more readable
rverelabs
added a commit
to rverelabs/gunicorn
that referenced
this pull request
Sep 27, 2024
commit e4b5d48 Merge: a24ff07 ec52843 Author: Benoit Chesneau <bchesneau@gmail.com> Date: Sat Aug 10 10:23:20 2024 +0200 Merge pull request benoitc#3188 from tnusser/patch-1 Update sock.py by making bind list creation more readable commit ec52843 Author: Tobias Nusser <tobiasnusser@web.de> Date: Wed Apr 17 12:48:26 2024 +0200 Update sock.py by making bind list creation more readable Implementing suggestion by reviewer benoitc#3127 (comment) to make code more readable. commit a24ff07 Author: Randall Leeds <randall@bleeds.info> Date: Thu Dec 28 00:57:50 2023 -0800 Use plain socket objects instead of wrapper classes Refactor socket creation to remove the socket wrapper classes so that these objects have less surprising behavior when used in worker hooks, worker classes, and custom applications. Close benoitc#3013.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor socket creation to remove the socket wrapper classes so that these objects have less surprising behavior when used in worker hooks, worker classes, and custom applications.
Close #3013.