Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utime instead of fchmod in WorkerTmp.notify #3095

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Use utime instead of fchmod in WorkerTmp.notify #3095

merged 1 commit into from
Nov 18, 2023

Conversation

ramikg
Copy link
Contributor

@ramikg ramikg commented Nov 14, 2023

This PR uses utime to update the "Changed" timestamp of the worker's temporary file, instead of calling fchmod(fd, 0) & fchmod(fd, 1) back-and-forth (which may be problematic in some restrictive environments).

This change was made possible in Python 3.3, which added support for calling utime with a file descriptor.

@benoitc benoitc merged commit 571b6ff into benoitc:master Nov 18, 2023
9 checks passed
@benoitc
Copy link
Owner

benoitc commented Nov 18, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants