Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise bounds check for MCL #118

Merged
merged 14 commits into from
Nov 6, 2023
Merged

Revise bounds check for MCL #118

merged 14 commits into from
Nov 6, 2023

Conversation

bennibolm
Copy link
Owner

As for the IDP limiting, the bounds check now also exports the maximum deviation since the last export.

@github-actions
Copy link

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

amrueda
amrueda reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@amrueda amrueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me. A couple of minor comments below.

examples/tree_2d_dgsem/elixir_euler_sedov_blast_wave_MCL.jl Outdated Show resolved Hide resolved
src/solvers/dgsem_tree/subcell_limiters_2d.jl Outdated Show resolved Hide resolved
src/solvers/dgsem_tree/subcell_limiters_2d.jl Outdated Show resolved Hide resolved
test/test_tree_2d_euler.jl Outdated Show resolved Hide resolved
bennibolm and others added 7 commits October 27, 2023 14:40
@bennibolm
Rename idp_bounds_delta for MCL to mcl_bounds_delta
add1d89
@bennibolm
Remove comment
62fd8ab
@DanielDoehring
Fix allocs (trixi-framework#1695)
28500ea 
* Fix allocs

* remove unnecessary code

* rerun fmt

* format
@DanielDoehring
Allocation tests dgmulti 2d (trixi-framework#1698)
abd97b1
@DanielDoehring @ranocha
HLLE CEE 2D3D NonCartesian Meshes (trixi-framework#1692)
c438d34 
* HLLE CEE 2D3D NonCartesian Meshes

* format

* hlle via hll

* format test

* format test

* format

* do not export hlle

* Correct test vals

* test values CI

* Update src/equations/compressible_euler_2d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update src/equations/compressible_euler_1d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update src/equations/compressible_euler_2d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update src/equations/compressible_euler_3d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update src/equations/compressible_euler_3d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* apply suggestions

* additional sentence

* Fix typo

* typos

* correct test vals

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@dependabot
Bump crate-ci/typos from 1.16.15 to 1.16.21 (trixi-framework#1700)
08a2e09 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.16.15 to 1.16.21.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.16.15...v1.16.21)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bennibolm
Merge branch 'subcell-limiting' into subcell-limiting-boundscheck-MCL
4b5b7db
sloede and others added 5 commits November 3, 2023 10:45
@sloede
Add NumFOCUS + ACTRIX to acknowledgments (trixi-framework#1697)
2ec512c 
* Add NumFOCUS + ACTRIX to acknowledgments

* Try to avoid spaces

* Another try to avoid gaps between images

* Hopefully fix image alignment in docs

* Try new logo formats

* Use smaller DUBS logo and add DUBS funding statement

* Add markdown-based table for logos in docs

* Try another table approach

* Hopefully get a layout that finally *works*...

* Arrrrrrgggggghhhhh
@ranocha
format examples (trixi-framework#1531)
c79fa43 
* format examples

* check formatting of examples in CI

* update style guide

* fix weird formatting

* fix formatting of binary operators

* format again
@ArseniyKholod
Update differentiable_programming.jl (trixi-framework#1704)
158e533
@bennibolm
Merge branch 'main' into subcell-limiting-boundscheck-MCL
ec681bb
@bennibolm
Format subcell elixirs
d4ae46d
amrueda
amrueda reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@amrueda amrueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!
Just a minor comment:

src/callbacks_stage/subcell_bounds_check.jl Show resolved Hide resolved
@bennibolm bennibolm merged commit cb899fe into subcell-limiting Nov 6, 2023
@bennibolm bennibolm deleted the subcell-limiting-boundscheck-MCL branch November 6, 2023 11:25
@bennibolm bennibolm restored the subcell-limiting-boundscheck-MCL branch November 6, 2023 11:27
bennibolm added a commit that referenced this pull request Nov 6, 2023
@bennibolm
Revert "Revise bounds check for MCL (#118)"
b854204 
This reverts commit cb899fe.
@bennibolm bennibolm deleted the subcell-limiting-boundscheck-MCL branch November 6, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrueda amrueda amrueda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bennibolm @amrueda @DanielDoehring @sloede @ranocha @ArseniyKholod