Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: history buffer #139

Closed
wants to merge 14 commits into from
Closed

feat: history buffer #139

wants to merge 14 commits into from

Conversation

benlubas
Copy link
Owner

@benlubas benlubas commented Jan 22, 2024

closes #138

Currently MVP. There's a split history window that shows the history of the current cell when you open it.

TODO:

  • Auto Update
  • Images with autoupdate... it seems to work for the first few runs, and then starts breaking horribly
  • Okay, this one isn't really done. It still causes rendering issues after running a cell that produces an image too many times after the history buffer is created.
  • [ ] Ability to show global history
  • [ ] Timestamps?
  • history window images should get separate image IDs to the virtual text image in the buffer, otherwise they will disappear (maybe only if auto update isn't on).
  • clear images on buffer close (calling history while buffer is open already will break things right now
  • README, and other doc updates

I think that I'm going to scrap the ability to view this in a floating window. Doesn't seem that useful to me.

Also pushing time stamps and global history to later PRs b/c this one is already really big.

@benlubas
Copy link
Owner Author

benlubas commented Jan 26, 2024

the problem with images is just a problem in general with running things while splits are open.

@benlubas
Copy link
Owner Author

I think I'm dealing with an image.nvim bug here. when the history buffer exists (even if it's not open), image rendering breaks.

image

The reason I think this is an image.nvim issue, is that causing a re-render (either by folding and unfolding or by unfocusing and refocusing the editor) will render the images like normal.

@benlubas
Copy link
Owner Author

benlubas commented Feb 6, 2024

I think this will have to wait for the image.nvim rewrite..

Hopefully that will fix a lot of the bugs that this PR is dealing with.

@benlubas
Copy link
Owner Author

benlubas commented Feb 8, 2024

The latest image.nvim change fixed the worst of these problems. There are still some issues with images unlinking themselves and hanging around though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] History
1 participant