Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nnloglik_mod: ensure modZ remains a matrix after dropping duplicate columns #9

Merged
merged 1 commit into from
May 14, 2018

Conversation

ck37
Copy link
Contributor

@ck37 ck37 commented May 14, 2018

Hello,

Here is a quick fix to CC_nnloglik_mod to add a drop = FALSE when removing duplicate columns. I ran into the issue while testing a placeholder library with only two learners, and it ends up causing an error when ncol(modZ) is called while creating the bounds.

Thanks,
Chris

@benkeser benkeser merged commit f4cbd24 into benkeser:master May 14, 2018
@benkeser
Copy link
Owner

thanks, Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants