Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getKey & forgetKey API's to OptimisticWrapperFunction #188

Closed
sofianhn opened this issue Apr 22, 2021 · 1 comment
Closed

Add getKey & forgetKey API's to OptimisticWrapperFunction #188

sofianhn opened this issue Apr 22, 2021 · 1 comment

Comments

@sofianhn
Copy link
Contributor

Per the conversation in apollographql/apollo-feature-requests#289, add getKey & forgetKey API's to OptimisticWrapperFunction.

The motive here is to keep track of the cached entries without having to memoize the arguments and duplicate the logic for weakly tracking them. This will enable the creators of OptimisticWrapperFunction to use the true keys for removing entries via the forgetKey API.
sofianhn pushed a commit to sofianhn/optimism that referenced this issue Apr 22, 2021
add getKey and forgetKey API (benjamn#188)
cfa780b
sofianhn pushed a commit to sofianhn/optimism that referenced this issue Apr 22, 2021
add getKey and forgetKey API (benjamn#188)
a592e8e
@benjamn
Copy link
Owner

benjamn commented May 8, 2021

Implemented in #189. Thanks!

@benjamn benjamn closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamn @sofianhn