Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CircleCI #28

Merged
merged 1 commit into from
May 21, 2019
Merged

Set up CircleCI #28

merged 1 commit into from
May 21, 2019

Conversation

paulmelnikow
Copy link
Collaborator

@paulmelnikow paulmelnikow commented May 10, 2019

This is an alternative to for #15 / #12. See my comment at #12 (comment).

I tested and iterated on this in my fork and you can see the successful run here: https://circleci.com/gh/paulmelnikow/tmp-promise/7.

To take advantage of this, you'd need to sign up for CircleCI yourself, and tell it to start building this repo:

https://circleci.com/docs/2.0/first-steps/

There isn't a way to delegate that without transferring the repo into a GitHub organization.

After you do that, I think this PR branch might build on its own. If not I can push another commit which should trigger the build.

@benjamingr
Copy link
Owner

Looks good to me - maybe add a badge to the readme?

I already use circle for a bunch of things - I'll try to get this set up when I'm back from DevDays thanks.

@paulmelnikow
Copy link
Collaborator Author

Hey Benjamin, could you turn this on?

@benjamingr benjamingr merged commit bd2e207 into benjamingr:master May 21, 2019
@benjamingr
Copy link
Owner

Sure, will configure it in circle

@benjamingr
Copy link
Owner

Added badge + configuration - thanks!

@benjamingr
Copy link
Owner

Also released 2.0.1

@paulmelnikow
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants