Convert to util.promisify and async/await

[paulmelnikow]

Ref #23 (comment)

Rather than wrapping the callback generically, it seems clearest to produce the correct output value all at once.

I'm getting a test failure locally on withDir, though I have the same failure in master. Any ideas what's causing that?

[benjamingr]

Thanks a bunch, this generally LGTM.

Need to shim Promise.prototype.finally since it's only available on Node 10+

[paulmelnikow]

If we're targeting Node 8+, Is there any reason not to write withFile and withDir using async / await?

[benjamingr]

If we're targeting Node 8+, Is there any reason not to write withFile and withDir using async / await?

Not at all, change to async/await welcome. We can just use regular finally instead of .finally in that case.

[paulmelnikow]

Updated!

The await in the finally block fixes the failing test – which it appears was a real failure 😲

[benjamingr]

Looks great, thanks.

[benjamingr]

I have invited you to the project by the way. With the other maintainers being @whmountains and @dlee-nvisia :]

[benjamingr]

Published 2.0 (wanted to be on the safe side)

[paulmelnikow]

Thank you! Look forward to helping.