replace mkstemps with mkstemp #2
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I had to rebase this as #1 landed :D. Its done now. |
|
@thefourtheye I have to keep compatibility with https://github.com/raszi/node-tmp |
|
I submitted a patch there raszi/node-tmp#77. Let's see if it gets through. |
|
Ok, leaving open to track |
|
@benjamingr The other PR got accepted :-) |
|
Great, can you add it to the code as another name of the old one and keep the old one (in code, not docs) for BC? |
|
nevermind, I'll do it. |
|
Wait, it's not actually a function - just a reference, lol, thanks :) |
benjamingr
added a commit
that referenced
this pull request
Feb 25, 2016
replace mkstemps with mkstemp
|
@benjamingr Thanks :-) Yes, the function name was correct only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
syntaxsignature resemblesmkstemp, notmkstemps