Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chalk platform undefined error by upgrading the version #332

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

arjunvegda
Copy link
Contributor

fixes #315

  • Tests pass locally, however, I cannot test it on the browser (having trouble running gulp locally)
  • Why not chalk@5.1.0? I'm playing it safe as chalk>=5 is pure ESM and I have very little knowledge of how this library operates 😅

@arjunvegda
Copy link
Contributor Author

Hey @benjamine - Could you please take a look at this super tiny PR when you get a moment?

@arjunvegda
Copy link
Contributor Author

@benjamine Gentle bump - Could you take a look at this or add me as a collaborator? I'm happy to help release this.

Copy link
Collaborator

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delay in getting this fixed!

I went ahead and downgraded chalk to 3.0.0 to avoid the breaking change of not supporting Node.js 8 in chalk 4.

I tested that console coloring still works using the docs/demo/consoledmo.js. I also tested that this fixes usage by Vite with a local app.

Ideally we would not be importing from chalk at all in a browser context, but that change is more complicated due to the older tech stack that jsondiffpatch currently uses. In the future we'll hopefully fix this by having a browser bundler-friendly ESM build, but that doesn't exist yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process is not defined
2 participants