Refactored Synchroniser to use simpler self._futures construct #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # (spec.BasicGetOK, spec.BasicGetEmpty) | ||
| for other_method in bound_methods: | ||
| if other_method != method: | ||
| self._futures[other_method].remove((fut, bound_methods)) |
There was a problem hiding this comment.
This is potentially expensive. deque.remove has to search through the deque for the item it's looking for, and removing it means copying a potentially large number of other items into place. In other words remove is O(n), whereas the OrderedDict version was amortised O(1).
There was a problem hiding this comment.
Ok, I think I know how to fix this right away.
|
Fixed |
|
GH won't let me merge it because there are conflicts. Please could you resolve them? |
TarasLevelUp
force-pushed
the
refactor_syncronizer
branch
from
5924c79 to
bf2a93b
Compare
|
done |
|
bump, if no more problems, merge this one pls. |
benjamin-hodgson
pushed a commit
that referenced
this pull request
Oct 16, 2015
Refactored Synchroniser to use simpler self._futures construct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will ease work on #34, as it remembers the exception, the synchroniser was killed with to raise them later.