Refactor internals. Fix finalizers. #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove async tasks in internals if possible. * Refactored routing components to be more simple instead of complex ManyToMany maps * Changed finalizers to be more straight and cover more cases.
TarasLevelUp
changed the title
|
Will add some tests to fix up coverage on weekend. Wanted to get feedback on code changes as soon as possible, so didn't look that deep on coverage, sorry. |
|
Upon a skim-read this code looks good, but the wide scope of this pull request makes it hard to review. Do you think you could split up your changes into logical units and submit them as separate patches? For example, one PR for the |
|
Yes, I can. Will do on weekend then |
|
Oh that's great, thanks. Looking forward to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the purpose of such a refactor:
asynctasks from QueueReader and ChannelActor so we don't need to use _TEST hack and for speed reasons Refactor QueueReader to use single async task #44 .In the process I saw some places, that could be optimised:
drain()from transport writes. I use it on close, so we inform server before closing connection (sending CloseOK may not be enough if buffers are full.)Feel free to comment on things, you consider needs changing. I think the way I pass ConnectionClose to be dispatched to all Writers is a bit ugly and Synchroniser's way to save future for more than 1 method can be written more cleanly.