refactor(tests): move bank PDF fixtures to same dir as test files

benjamin-awd · Oct 29, 2023 · 10ac6a7 · 10ac6a7
1 parent d32784f
commit 10ac6a7
Show file tree

Hide file tree

Showing 19 changed files with 19 additions and 516 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1 +1 @@
-tests/integration/fixtures/**/input.pdf filter=git-crypt diff=git-crypt
+tests/integration/banks/**/input.pdf filter=git-crypt diff=git-crypt
diff --git a/.gitignore b/.gitignore
@@ -16,7 +16,7 @@ _ignore*
 
 # allowed pdf files/fixtures
 !tests/integration/fixtures/*/**
-!tests/integration/fixtures/*.pdf
+!tests/integration/banks/**/*.pdf
 !monopoly/examples/*.pdf
 
 # john files

diff --git a/...s/integration/fixtures/citibank/input.pdf → tests/integration/banks/citibank/input.pdf b/...s/integration/fixtures/citibank/input.pdf → tests/integration/banks/citibank/input.pdf
diff --git a/tests/integration/fixtures/dbs/input.pdf → tests/integration/banks/dbs/input.pdf b/tests/integration/fixtures/dbs/input.pdf → tests/integration/banks/dbs/input.pdf
diff --git a/tests/integration/fixtures/hsbc/input.pdf → tests/integration/banks/hsbc/input.pdf b/tests/integration/fixtures/hsbc/input.pdf → tests/integration/banks/hsbc/input.pdf
diff --git a/tests/integration/fixtures/ocbc/input.pdf → tests/integration/banks/ocbc/input.pdf b/tests/integration/fixtures/ocbc/input.pdf → tests/integration/banks/ocbc/input.pdf
diff --git a/...ion/fixtures/standard_chartered/input.pdf → ...ration/banks/standard_chartered/input.pdf b/...ion/fixtures/standard_chartered/input.pdf → ...ration/banks/standard_chartered/input.pdf
diff --git a/tests/integration/banks/test_banks.py b/tests/integration/banks/test_banks.py
@@ -1,4 +1,5 @@
 from datetime import datetime
+from pathlib import Path
 
 import pandas as pd
 import pytest
@@ -22,13 +23,11 @@
 )
 def test_bank_operations(bank_class: BankBase, total_amount, statement_date):
     bank_name = bank_class.statement_config.bank_name
-    bank: BankBase = bank_class(
-        file_path=f"tests/integration/fixtures/{bank_name}/input.pdf"
-    )
-    raw_data = pd.read_csv(f"tests/integration/fixtures/{bank_name}/raw.csv")
-    transformed_data = pd.read_csv(
-        f"tests/integration/fixtures/{bank_name}/transformed.csv"
-    )
+
+    fixture_directory = Path(__file__).parent / bank_name
+    bank: BankBase = bank_class(file_path=fixture_directory / "input.pdf")
+    raw_data = pd.read_csv(fixture_directory / "raw.csv")
+    transformed_data = pd.read_csv(fixture_directory / "transformed.csv")
 
     # Check extracted data is correct
     statement: Statement = bank.extract()

diff --git a/tests/integration/fixtures/citibank/raw.csv b/tests/integration/fixtures/citibank/raw.csv
diff --git a/tests/integration/fixtures/citibank/transformed.csv b/tests/integration/fixtures/citibank/transformed.csv
diff --git a/tests/integration/fixtures/dbs/raw.csv b/tests/integration/fixtures/dbs/raw.csv
diff --git a/tests/integration/fixtures/dbs/transformed.csv b/tests/integration/fixtures/dbs/transformed.csv
diff --git a/tests/integration/fixtures/hsbc/raw.csv b/tests/integration/fixtures/hsbc/raw.csv
diff --git a/tests/integration/fixtures/hsbc/transformed.csv b/tests/integration/fixtures/hsbc/transformed.csv
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		tests/integration/fixtures/**/input.pdf filter=git-crypt diff=git-crypt
		tests/integration/banks/**/input.pdf filter=git-crypt diff=git-crypt