ike: do not log empty notify array

Ticket: OISF#5167
benignbala · Nov 12, 2022 · 89339ee · 89339ee
1 parent 74c2d96
commit 89339ee
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/rust/src/ike/logger.rs b/rust/src/ike/logger.rs
@@ -214,12 +214,14 @@ fn log_ikev2(tx: &IKETransaction, jb: &mut JsonBuilder) -> Result<(), JsonError>
     jb.open_object("ikev2")?;
 
     jb.set_uint("errors", tx.errors as u64)?;
-    jb.open_array("notify")?;
-    for notify in tx.notify_types.iter() {
-        jb.append_string(&format!("{:?}", notify))?;
+    if !tx.notify_types.is_empty() {
+        jb.open_array("notify")?;
+        for notify in tx.notify_types.iter() {
+            jb.append_string(&format!("{:?}", notify))?;
+        }
+        jb.close()?;
     }
     jb.close()?;
-    jb.close()?;
     Ok(())
 }