forked from rust-lang/rust-clippy
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
6 changed files
with
101 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| use crate::utils::{is_integer_const, span_lint_and_sugg, unsext}; | ||
| use if_chain::if_chain; | ||
| use rustc_errors::Applicability; | ||
| use rustc_hir::*; | ||
| use rustc_lint::{LateContext, LateLintPass}; | ||
| use rustc_middle::ty::{self}; | ||
| use rustc_session::{declare_lint_pass, declare_tool_lint}; | ||
|
|
||
| declare_clippy_lint! { | ||
| /// Finds usages of is_digit that can be replaced with is_ascii_digit or is_ascii_hexdigit. | ||
| /// | ||
| /// **Why is this bad?** | ||
| /// | ||
| /// **Known problems:** None. | ||
| /// | ||
| /// **Example:** | ||
| /// | ||
| /// ```rust | ||
| /// // c.is_digit(10) | ||
| /// // c.is_digit(16) | ||
| /// ``` | ||
| /// Use instead: | ||
| /// ```rust | ||
| /// c.is_ascii_digit() | ||
| /// c.is_ascii_hexdigit() | ||
| /// ``` | ||
| pub IS_DIGIT_SIMPLIFY, | ||
| style, | ||
| "Finds usages of is_digit that can be replaced with is_ascii_digit or is_ascii_hexdigit" | ||
| } | ||
|
|
||
| declare_lint_pass!(IsDigitSimplify => [IS_DIGIT_SIMPLIFY]); | ||
|
|
||
| impl LateLintPass<'_> for IsDigitSimplify { | ||
| fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) { | ||
| if_chain! { | ||
| // calling is_digit | ||
| if let ExprKind::MethodCall(path, span, args, _) = &expr.kind; | ||
| if path.ident.name == sym!(is_digit); | ||
|
|
||
| // on a char | ||
| if args.len() == 2; | ||
| if let ty::Char = cx.typeck_results().expr_ty(&args[0]).kind(); | ||
|
|
||
| // with an integral parameter | ||
| if let ty::Int(ity) = cx.typeck_results().expr_ty(&args[1]).kind(); | ||
| then { | ||
| let messages = if is_integer_const(cx, &args[1], unsext(cx.tcx, 10, *ity)) { | ||
| Some(("is_digit with decimal radix", "consider using is_ascii_digit")) | ||
| } else if is_integer_const(cx, &args[1], unsext(cx.tcx, 16, *ity)) { | ||
| Some(("is_digit with hexadecimal radix", "consider using is_ascii_hexdigit")) | ||
| } else { | ||
| None | ||
| }; | ||
|
|
||
| if let Some((reason, sugg)) = messages { | ||
| span_lint_and_sugg(cx, IS_DIGIT_SIMPLIFY, *span, reason, "try", String::from(sugg), Applicability::MachineApplicable) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #![warn(clippy::is_digit_simplify)] | ||
|
|
||
| fn main() { | ||
| // test code goes here | ||
| } |