Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary argument #621

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Remove unnecessary argument #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52da180
Remove unnecessary argument
Soonmok Oct 4, 2022
d66be68
Merge branch 'main' into main
benfred Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion implicit/_nearest_neighbours.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ cdef class NearestNeighboursScorer(object):
self.lock = threading.RLock()

@cython.boundscheck(False)
def recommend(self, int u, int[:] user_indptr, int[:] user_indices, floating[:] user_data,
def recommend(self, int[:] user_indptr, int[:] user_indices, floating[:] user_data,
int K=10, bool remove_own_likes=True):
cdef int index1, index2, i, count
cdef double weight
Expand Down
1 change: 0 additions & 1 deletion implicit/nearest_neighbours.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ def recommend(
raise IndexError("Some of selected itemids are not in the model")

ids, scores = self.scorer.recommend(
userid,
user_items.indptr,
user_items.indices,
user_items.data,
Expand Down