Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Fit items problem adding items #556

Closed
edoardoscarpaci opened this issue Apr 5, 2022 · 1 comment · Fixed by #563
Closed

Partial Fit items problem adding items #556

edoardoscarpaci opened this issue Apr 5, 2022 · 1 comment · Fixed by #563

Comments

@edoardoscarpaci
Copy link

When adding a new items it results in a problem because if the index used for the new item is the same as the dimensions of the item_factors matrix it doesn't update the dimension because in the line 325 (if max_itemid = items:) there should be >= and not only the = sign.
@benfred
Copy link
Owner

benfred commented Apr 11, 2022

Thanks for the bug report! It does seem likely that there is an off-by-one error here

benfred added a commit that referenced this issue Apr 12, 2022
@benfred
Fix partial_fit_items bug with only growing by a single item
dadf8bc 
When trying to update with exactly 1 new item, partial_fit_items would
throw an exception since we had an off-by-one error in allocating
factor storage. Fix and add a unittest that would catch this.

Closes #556
@benfred benfred mentioned this issue Apr 12, 2022
Merged
benfred added a commit that referenced this issue Apr 12, 2022
@benfred
Fix partial_fit_items bug with only growing by a single item (#563)
6491663 
When trying to update with exactly 1 new item, partial_fit_items would
throw an exception since we had an off-by-one error in allocating
factor storage. Fix and add a unittest that would catch this.

Closes #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix partial_fit_items bug with only growing by a single item benfred/implicit
2 participants
@benfred @edoardoscarpaci