Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed parameter maximum_number_of_iterations #106

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Exposed parameter maximum_number_of_iterations #106

merged 2 commits into from
Aug 1, 2022

Conversation

LucaCappelletti94
Copy link
Collaborator

On some inputs, methods based on ARPACK may fail because of missed convergence. The default value on scipy is a bit too strict (maxiter = 10*number_of_nodes), so I have exposed the parameter and set it as default to (maxiter = 100*number_of_nodes).

So far, I have encountered convergence issues only in this model, as computing the smallest eigenvectors can be more complicated than the largest ones. If I encounter this issue in other models, I will also make a pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #106 (678e9fd) into master (1165e48) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          61       61           
  Lines        2595     2596    +1     
=======================================
+ Hits         2525     2526    +1     
  Misses         70       70           
Impacted Files Coverage Δ
...node_embedding/neighbourhood/laplacianeigenmaps.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@benedekrozemberczki benedekrozemberczki merged commit 3a4896c into benedekrozemberczki:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants