Exposed parameter maximum_number_of_iterations
#106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some inputs, methods based on ARPACK may fail because of missed convergence. The default value on scipy is a bit too strict (
maxiter = 10*number_of_nodes
), so I have exposed the parameter and set it as default to (maxiter = 100*number_of_nodes
).So far, I have encountered convergence issues only in this model, as computing the smallest eigenvectors can be more complicated than the largest ones. If I encounter this issue in other models, I will also make a pull request.