Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown rendering of summary-always broken #159

Closed
embano1 opened this issue Mar 12, 2023 · 5 comments · Fixed by #218
Closed

Markdown rendering of summary-always broken #159

embano1 opened this issue Mar 12, 2023 · 5 comments · Fixed by #218

Comments

@embano1
Copy link

embano1 commented Mar 12, 2023

The markdown formatting to numbers seems to not be applied (perhaps due to some HTML interpretation issue?), example: https://github.com/timbray/quamina/actions/runs/4393672754

@miparnisari
Copy link
Contributor

@embano1
Copy link
Author

embano1 commented Dec 29, 2023

Same for you, see the ticks around the numbers in the Current and Previous columns.

@miparnisari
Copy link
Contributor

@embano1 oh, lol.

@miparnisari
Copy link
Contributor

miparnisari commented Jan 2, 2024

I think that is set here

line = `| \`${current.name}\` | ${strVal(current)} | ${strVal(prev)} | \`${floatStr(ratio)}\` |`;
} else {
line = `| \`${current.name}\` | ${strVal(current)} | | |`;
}
lines.push(line);

function strVal(b: BenchmarkResult): string {
let s = `\`${b.value}\` ${b.unit}`;
if (b.range) {
s += ` (\`${b.range}\`)`;
}
return s;
}

@ktrz
Copy link
Member

ktrz commented Jan 26, 2024

released in v1.19.2

XSAM added a commit to open-telemetry/opentelemetry-go that referenced this issue Jul 5, 2024
It enables the job summary for triggered PRs. (it doesn't create a
comment in PRs) Example:
benchmark-action/github-action-benchmark#159 (comment)

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants