-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More CI (mypy, coverage), setup pre-commit, formatting #24
Conversation
ExperimentalAutoDetectBinPacking: false | ||
AllowAllParametersOfDeclarationOnNextLine: false | ||
AllowShortFunctionsOnASingleLine: Empty | ||
AllowShortLambdasOnASingleLine: Inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any opinion about how C++ code should look like, and how much we want to customize compared to the base Google style (so happy to follow your preferences). But just to consider, s2geography just follows google (https://github.com/paleolimbot/s2geography/blob/master/.clang-format), and arrow uses only minimal overrides (https://github.com/apache/arrow/blob/main/.clang-format)
(but so +1 on adding a linter for this to enforce consistent style!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinions either and I think it is a good idea to stay close to the Google style used by s2geography and not add too much customization. This is just to fix some minor things I find annoying, like packing some of the parameters on the same line when all the parameters don't fit on one line, e.g., I prefer this:
m.def("equals",
py::vectorize(Predicate(s2geog::s2_equals)),
py::arg("a"),
py::arg("b"));
over this:
m.def("equals", py::vectorize(Predicate(s2geog::s2_equals)), py::arg("a"),
py::arg("b"));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, I don't mind (as long as it is automated), so just follow your preferences ;)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage ? 56.07%
=======================================
Files ? 5
Lines ? 214
Branches ? 95
=======================================
Hits ? 120
Misses ? 7
Partials ? 87 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Switching to micromamba make things even faster! Also the cache is a bit more reliable now (it seems to fix issues on Windows). @jorisvandenbossche any other comment or suggestion before I merge this? |
No description provided.