Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEMHTML: Generate final .bemhtml.js with modules.define #47

Merged
merged 1 commit into from
Jun 11, 2013
Merged

Conversation

veged
Copy link
Member

@veged veged commented Jun 11, 2013

We can drop BEMHMTL from global scope and use modules system.

@ghost ghost assigned veged Jun 11, 2013
@veged
Copy link
Member Author

veged commented Jun 11, 2013

also close #49

veged added a commit that referenced this pull request Jun 11, 2013
BEMHTML: Generate final .bemhtml.js with `modules.define`
@veged veged merged commit 79cd360 into dev Jun 11, 2013
@@ -25,6 +25,8 @@ api.translate = function translate(source, options) {
' })({});',
' if(typeof exports === "object") {',
' exports["' + exportName + '"] = __xjst;',
' } else if(typeof modules === "object") {',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veged
В Node.js это не будет работать — там всегда есть exports (см. dfilatov/vow#26)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

спасибо, поправил

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants