-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Napa to CircleCI #241
Conversation
Sounds good. I would still love to see the CI running the rubocop check though. @darbyfrey |
👍 for CircleCI (once passing), though you might need to find a way to tell it not to run |
machine: | ||
ruby: | ||
version: | ||
2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/nitpick, new line
@danielmackey build is green now @ochagata want to update your PR to run rubocop once I merge this in? If I can get a +1 I'll merge this one in right away |
+1 from me. |
@darbyfrey Yeah, I'll need to add an exclude for vendor. It included it and started running rubocop for all gems. I'll make the commit tomorrow |
@darbyfrey Might need to change the config on either github or travis to make the builds stop, since the last commit had a failed build due to a missing |
@ochagata it's just to put us in the mood for Christmas 🎄 ;-) |
@bellycard/platform
@ochagata We use CircleCI for everything else at Belly, but we haven't moved Napa over yet - now seems like a good time.