Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thor command to start shotgun server. #177

Merged
merged 2 commits into from
Feb 3, 2015
Merged

Add thor command to start shotgun server. #177

merged 2 commits into from
Feb 3, 2015

Conversation

cpursley
Copy link
Contributor

Add napa server command to start the shotgun server similar to rails server in Ruby on Rails.

@@ -63,6 +63,28 @@ def console(environment = nil)
interpreter.start
end

desc 'server', "Start the Napa server"
options aliases: 'c'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the alias be 's'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks @shaqq

@umtrey
Copy link
Contributor

umtrey commented Jan 26, 2015

+1 from me

@shaqq
Copy link
Contributor

shaqq commented Feb 3, 2015

👍 working as expected.

Maybe in the future we can have Napa configured to use whatever Rack server you want (unicorn, thin, mongrel, etc.), and napa server responds accordingly.

Nice add, @cpursley!

shaqq added a commit that referenced this pull request Feb 3, 2015
Add thor command to start shotgun server.
@shaqq shaqq merged commit be4f86b into bellycard:master Feb 3, 2015
@cpursley
Copy link
Contributor Author

cpursley commented Feb 3, 2015

I was thinking that exact same thing @shaqq regarding choice of Rack server.

@shaqq
Copy link
Contributor

shaqq commented Feb 3, 2015

We also need to figure out a way to test these features, since many of the CLI commands don't work unless you're in the root directory of an app.

@cpursley cpursley deleted the c/server-command branch February 3, 2015 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants