Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msbuild unformatted files are no longer treated as error on linux #1396

Merged
merged 6 commits into from
Dec 7, 2024

Conversation

belav
Copy link
Owner

@belav belav commented Dec 6, 2024

The changes for #1311 seem to work in windows, but cause problems in linux. Files that aren't formatted are no longer treated as errors.

closes #1357

@belav belav changed the title Msbuild issue Msbuild unformatted files are no longer treated as error on linux Dec 6, 2024
@belav belav marked this pull request as ready for review December 7, 2024 18:57
@belav belav merged commit a03d440 into main Dec 7, 2024
4 checks passed
@belav belav deleted the msbuild-issue branch December 7, 2024 18:57
pisolofin pushed a commit to pisolofin/csharpier-editorconfig that referenced this pull request Dec 14, 2024
…lav#1396)

The changes for belav#1311 seem to
work in windows, but cause problems in linux. Files that aren't
formatted are no longer treated as errors.

closes belav#1357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csharpier as msbuild dependency doesn't fail the github action anymore
1 participant