Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild - when a file fails to compile csharpier interferes with getting you clickable links to the compilation errors. #957

Closed
belav opened this issue Sep 8, 2023 · 0 comments · Fixed by #959
Closed

MSBuild - when a file fails to compile csharpier interferes with getting you clickable links to the compilation errors. #957

belav opened this issue Sep 8, 2023 · 0 comments · Fixed by #959
Labels
area:msbuild priority:high type:bug Something isn't working
Milestone
0.26.0

Comments

@belav
Copy link
Owner

belav commented Sep 8, 2023

So, it turns out doing this broke error output:
Since CSharpier now runs before compilation, when a unit fails to compile, the regular compilation target is not run.
This means the error messages that IDEs (including VSCode) can pick up are not emitted.

image

15061de#r126341275

We can probably just ignore the result of running csharpier, or output the result but still continue on.
@belav belav added this to the 0.26.0 milestone Sep 8, 2023
@belav belav added priority:high type:bug Something isn't working area:msbuild labels Sep 8, 2023
belav referenced this issue Sep 8, 2023
@belav
Ensure csharpier formatting happens before compiling so that breakpoi…
15061de 
…nts work properly (#675)

closes #674
belav added a commit that referenced this issue Sep 10, 2023
@belav
Ensure that compilation errors surface properly when building a proje…
b48539a 
…ct with CSharpier.msbuild in debug

closes #957
@belav belav mentioned this issue Sep 10, 2023
Merged
@belav belav mentioned this issue Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:msbuild priority:high type:bug Something isn't working
Projects
None yet
Milestone
0.26.0
1 participant
@belav