Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need documentation when using ! in an environment variable value #169

Closed
macdonst opened this issue Jan 11, 2024 · 0 comments
Closed

Need documentation when using ! in an environment variable value #169

macdonst opened this issue Jan 11, 2024 · 0 comments
Assignees

Comments

@macdonst
Copy link
Member

When you run the command:

begin env create -e staging -n API_KEY -v fake!key
# or
begin env create -e staging -n API_KEY -v "fake!key"

The command fails to execute. Which is not surprising since the ! needs to be escaped like:

begin env create -e staging -n API_KEY -v "fake\!key"

but this is not immediately apparent to users. The situation is even worse on Windows (PowerShell) where the command:

begin env create -e staging -n API_KEY -v fake!key

sets and API_KEY to the value fake.

Expected behaviour

We should update our documentation to add the double quotes around environment variable values and show an example of an escaped value.

Steps to reproduce

Run the command:

begin env create -e staging -n 1API_KEY -v fake!key

Platform version

  • MacOS 14.2.1
  • Begin version: main-21f0079
  • Node.js v18.15.0

Also reported by a user at our workshop on Windows. I will attempt to reproduce when I get to a Windows machine.

macdonst added a commit that referenced this issue Jan 12, 2024
…e value

Signed-off-by: macdonst <simon.macdonald@gmail.com>
@macdonst macdonst self-assigned this Jan 12, 2024
macdonst added a commit that referenced this issue Jan 16, 2024
…e value

Signed-off-by: macdonst <simon.macdonald@gmail.com>
tbeseda added a commit that referenced this issue Jan 18, 2024
…e value (#170)

* Issue #169: Need documentation when using ! in an environment variable value

Signed-off-by: macdonst <simon.macdonald@gmail.com>

* change string quotes

---------

Signed-off-by: macdonst <simon.macdonald@gmail.com>
Co-authored-by: Taylor Beseda <tbeseda@gmail.com>
@tbeseda tbeseda closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants