Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy library which is required for OpenCV support #14

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jmortlock
Copy link
Contributor

I have added Numpy which is required for various filters and dectors in thumbor. In particular for us we are using the following detectors setup

        DETECTORS:
              "['thumbor.detectors.face_detector', 'thumbor.detectors.feature_detector']",

Version range came from this PR thumbor/thumbor#1537

@beeyev beeyev merged commit d5ba741 into beeyev:master Feb 13, 2023
@beeyev
Copy link
Owner

beeyev commented Feb 13, 2023

Thanks!
Do you think opencv-python-headless also needs to be included?

@jmortlock
Copy link
Contributor Author

I did have a look at this and I don't think it does, the reason being is that previously we have been using the docker image from this repository: https://github.com/mvhirsch/thumbor-docker/blob/f766bf614dedf4b54b84bbd3e558c7cc09c04ad4/7/alpine/Dockerfile and it does not have opencv-python-headless as an installed dependency.

If your able to get a release with this change out i would be happy to test and report back to you

@beeyev
Copy link
Owner

beeyev commented Feb 13, 2023

Okay, I will check it.
Thanks again for the participation! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants