Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List travertino before core when installing from local directories #3169

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Feb 7, 2025

#3155 added Travertino to the requirements list of all the example apps. But when installing from local directories, it looks like Chaquopy's old version of pip requires them to be listed in dependency order.

This also affects the testbed, but it didn't break CI because it was able to find a matching Travertino wheel in the dist directory.

Before:

> Task :app:generateDebugPythonRequirements
Chaquopy: Installing for arm64-v8a
Looking in indexes: https://pypi.org/simple, https://chaquo.com/pypi-13.1
Processing /Users/msmith/git/beeware/toga/core
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Processing /Users/msmith/git/beeware/toga/travertino
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Processing /Users/msmith/git/beeware/toga/android
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
ERROR: Could not find a version that satisfies the requirement travertino==0.4.9.dev572+gea6adab4d.d20250207 (from toga-core==0.4.9.dev572+gea6adab4d.d20250207->-r requirements.txt (line 2)) (from versions: 0.0.1, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.2.0, 0.3.0)
ERROR: No matching distribution found for travertino==0.4.9.dev572+gea6adab4d.d20250207 (from toga-core==0.4.9.dev572+gea6adab4d.d20250207->-r requirements.txt (line 2))
Chaquopy: Exit status 1

After:

> Task :app:generateDebugPythonRequirements
Chaquopy: Installing for arm64-v8a
Looking in indexes: https://pypi.org/simple, https://chaquo.com/pypi-13.1
Processing /Users/msmith/git/beeware/toga/travertino
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Processing /Users/msmith/git/beeware/toga/core
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Processing /Users/msmith/git/beeware/toga/android
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Building wheels for collected packages: travertino, toga-core, toga-android
  Building wheel for travertino (PEP 517): started
  Building wheel for travertino (PEP 517): finished with status 'done'
  Created wheel for travertino: filename=travertino-0.4.9.dev572+gea6adab4d.d20250207-py3-none-any.whl size=20577 sha256=5e3f997d7e99ec8bd349bdc4d256b966cc92c18749b98a6b781a2d6d6cebf68e
  Stored in directory: /private/var/folders/2t/th8vxc813_gcch7lkh1sbbmc0000gp/T/pip-ephem-wheel-cache-cef73mwd/wheels/50/68/06/96b21e14163f0edd24587f0067b9cb8c3bc865184fbbb3fe6f
  Building wheel for toga-core (PEP 517): started
  Building wheel for toga-core (PEP 517): finished with status 'done'
  Created wheel for toga-core: filename=toga_core-0.4.9.dev572+gea6adab4d.d20250207-py3-none-any.whl size=581485 sha256=244d13f319bd4ac6a2b133907bfb7990bc213236347a1dec97f148e9f66fd6fd
  Stored in directory: /private/var/folders/2t/th8vxc813_gcch7lkh1sbbmc0000gp/T/pip-ephem-wheel-cache-cef73mwd/wheels/66/ce/a3/586dd1554be23d847701b25f12e1fb23768f67797368f20536
  Building wheel for toga-android (PEP 517): started
  Building wheel for toga-android (PEP 517): finished with status 'done'
  Created wheel for toga-android: filename=toga_android-0.4.9.dev572+gea6adab4d.d20250207-py3-none-any.whl size=70773 sha256=8124afcdc3159ef0071d546c40466c44557c5573c9c7d12e34cf15ce8a7ff367
  Stored in directory: /private/var/folders/2t/th8vxc813_gcch7lkh1sbbmc0000gp/T/pip-ephem-wheel-cache-cef73mwd/wheels/95/bc/78/d17a7002f938ad322e179aaee572c8dce511468af9aeff854a
Successfully built travertino toga-core toga-android
Installing collected packages: travertino, toga-core, toga-android
Successfully installed toga-android-0.4.9.dev572+gea6adab4d.d20250207 toga-core-0.4.9.dev572+gea6adab4d.d20250207 travertino-0.4.9.dev572+gea6adab4d.d20250207

@mhsmith mhsmith force-pushed the travertino-dep-order branch from 69464fb to b0d3de9 Compare February 7, 2025 21:31
@mhsmith mhsmith requested a review from freakboy3742 February 7, 2025 22:41
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that it has that effect, but can't argue with the results.

I guess this only serves to highlight that we need to get the Android changes into pip.

@freakboy3742 freakboy3742 merged commit 7ea9b9f into beeware:main Feb 8, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants