Make Flake8 line limit consistent with Black and shorten lines to comply

[marcbradshaw]

Flake8 line limit is inconsistent with Black, this PR updates the config to be consistent, and shortens lines to comply with the new limit, as required.

Some lines with very long method names were skipped, ironically by making them even longer and adding a noqa comment

Fixes #2975

PR Checklist:

• All new features have been tested
• All new features have been documented
• I have read the CONTRIBUTING.md file
• I will abide by the code of conduct

[freakboy3742]

Those CI failures are mine - I'll get them fixed.

[mhsmith]

Please do not use a force push to alter commits which have already been reviewed, as it breaks the "Show changes since your last review" feature in GitHub. If you need to bring in changes from the main branch, you can use a merge rather than a rebase.

[mhsmith]

There's no consistency in the line lengths of the comments. For example:

• android/src/toga_android/widgets/label.py was previously 88 columns and has been reduced to 80.
• android/src/toga_android/libs/events.py was previously 95 columns and has been reduced to 88.
• cocoa/src/toga_cocoa/window.py was previously 88 columns and has been reduced to 60.

To avoid unnecessary noise and merge conflicts, I think we should do the following:

• If code is longer than 88 columns, reduce it to 88.
• If code is shorter than 88 columns, leave it unchanged.

Previous discussion: #2956 (comment)

[freakboy3742]

Agreed about the general guidelines - but:

• android/src/toga_android/widgets/label.py was previously 88 columns and has been reduced to 80.

There's only 1 change in this file, and it's because the first line is 89 chars. The new flow ends up with the second line being 88 chars. Have I misunderstood what you're referring to?

• android/src/toga_android/libs/events.py was previously 95 columns and has been reduced to 88.

Agreed.... but that's what we want, right?

[freakboy3742]

Ok - I've undone the damage I did yesterday 🤦 , and I've made a bunch of other tweaks following @mhsmith's notes. I'm happy with where this is now; I'll leave the final call to @mhsmith in case I've missed something he's concerned about.

[mhsmith]

• android/src/toga_android/widgets/label.py was previously 88 columns and has been reduced to 80.

There's only 1 change in this file, and it's because the first line is 89 chars. The new flow ends up with the second line being 88 chars. Have I misunderstood what you're referring to?

Sorry, you're right – I must have lost the indentation when I copied the line into an editor to measure it.

• android/src/toga_android/libs/events.py was previously 95 columns and has been reduced to 88.

Agreed.... but that's what we want, right?

Yes, I was just using it as a comparison.