Allow sphinx-autobuild time to shutdown http server in tox
#2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tox is apparently a bit aggressive in shutting down processes when it receives a CTRL+C; this can ultimately result in tox exiting and leaving the HTTP server still running requiring manual process kills. - I think this results from ``sphinx-autobuild`` receiving the SIGINT and starting its shutdown...but tox then sends it _another_ SIGINT that seems to abort the shutdown procedure for ``sphinx-autobuild``. - So, this gives ``sphinx-autobuild`` a window of time to shutdown before tox starts trying to help.
rmartin16
force-pushed
the
docs-live-shutdown
branch
from
794cf09 to
4ea3c24
Compare
freakboy3742
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sphinx-autobuildreceiving the SIGINT and starting its shutdown...but tox then sends it another SIGINT that seems to abort the shutdown procedure forsphinx-autobuild.sphinx-autobuilda window of time to shutdown before tox starts trying to help.PR Checklist: