Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the dev interpreter in PEP540 UTF8 mode. #985

Merged
merged 2 commits into from
Dec 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/985.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Development mode now starts apps in PEP540 UTF-8 mode, for consistency with the stub apps.
2 changes: 2 additions & 0 deletions src/briefcase/commands/dev.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ def run_dev_app(
"-u",
"-X",
"dev",
"-X",
"utf8",
"-c",
(
"import runpy, sys;"
Expand Down
8 changes: 8 additions & 0 deletions tests/commands/dev/test_run_dev_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ def test_subprocess_running_successfully(dev_command, first_app, tmp_path):
"-u",
"-X",
"dev",
"-X",
"utf8",
"-c",
(
"import runpy, sys;"
Expand Down Expand Up @@ -51,6 +53,8 @@ def test_subprocess_throws_error(dev_command, first_app, tmp_path):
"-u",
"-X",
"dev",
"-X",
"utf8",
"-c",
(
"import runpy, sys;"
Expand All @@ -77,6 +81,8 @@ def test_subprocess_test_mode_success(dev_command, first_app, tmp_path):
"-u",
"-X",
"dev",
"-X",
"utf8",
"-c",
(
"import runpy, sys;"
Expand Down Expand Up @@ -112,6 +118,8 @@ def test_subprocess_test_mode_failure(dev_command, first_app, tmp_path):
"-u",
"-X",
"dev",
"-X",
"utf8",
"-c",
(
"import runpy, sys;"
Expand Down