Add Python 3.12 support #965
Conversation
.github/workflows/ci.yml
Outdated
| platform: ['macos', 'ubuntu', 'windows'] | ||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | ||
| platform: ["macos", "ubuntu", "windows"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12.0-alpha - 3.12.0"] |
There was a problem hiding this comment.
This will have to be updated after 3.12.0 is released, otherwise it won't pick up 3.12.1 etc. Can we instead use the "x.y-dev" syntax shown here? If so, we might as well apply it to every version.
There was a problem hiding this comment.
-dev definitely makes sense for 3.12; I wasn't aware that syntax was an option.
I'm not convinced we want to adopt it for established releases, though. Looking at the tagged releases of Python, RCs of Python micro releases aren't that common; using 3.8-dev could communicate the impression that we're doing some sort of pre-release branch testing, which would only be the case if someone pushed a PR during the very limited window that an RC was available prior to the next final release.
| @@ -20,6 +20,7 @@ classifiers = | |||
| Programming Language :: Python :: 3.9 | |||
| Programming Language :: Python :: 3.10 | |||
| Programming Language :: Python :: 3.11 | |||
| Programming Language :: Python :: 3.12 | |||
There was a problem hiding this comment.
By declaring this. we're committing to fixing any Python 3.12 compatibility issues before each Briefcase release from now on, which should be manageable. But by adding it to CI the same way as the other versions, we would be forced to fix any Python 3.12 issues immediately, which could be inconvenient, and isn't necessary so early in the 3.12 release cycle.
Can we use the continue-on-error setting as shown here to make Python 3.12 failures non-fatal for now? Then we can make them fatal next year when it reaches RC status.
With the release of 3.12.0a1, we can start testing for 3.12 support.
PR Checklist: